> On Feb. 18, 2015, 12:41 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaRequestHandler.scala, line 108 > > <https://reviews.apache.org/r/30570/diff/2/?file=866690#file866690line108> > > > > I think the aggregate rates here are redundant to what's already there > > in RequestChannel's request metrics; but I think it is convenient to have > > it here as well.
Thanks! But do the ones in RequestChannel aggregate on a per-topic basis? - Aditya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review72845 ----------------------------------------------------------- On Feb. 17, 2015, 11:46 p.m., Aditya Auradkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30570/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 11:46 p.m.) > > > Review request for kafka and Joel Koshy. > > > Bugs: KAFKA-1914 > https://issues.apache.org/jira/browse/KAFKA-1914 > > > Repository: kafka > > > Description > ------- > > BrokerTopicStats changes to aggregate on a per-topic basis the total fetch > and produce requests > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaRequestHandler.scala > e4053fbe8ef78bf8bc39cb3f8ea4c21032613a16 > core/src/main/scala/kafka/server/ReplicaManager.scala > fb948b9ab28c516e81dab14dcbe211dcd99842b6 > core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala > ccf5e2e36260b2484181b81d1b06e81de972674b > > Diff: https://reviews.apache.org/r/30570/diff/ > > > Testing > ------- > > I've added asserts to the SimpleFetchTest to count the number of fetch > requests. I'm going to file an additional jira to add unit tests for all the > BrokerTopicMetrics updated via ReplicaManager > > > Thanks, > > Aditya Auradkar > >