> On Feb. 18, 2015, 10:16 p.m., Jun Rao wrote: > > Thanks for the patch. A couple of comments. > > > > 1. We already measure the total produce/fetch request rate in > > RequestMetrics. Now, we are duplicating that in BrokerTopics. Is there a > > way to avoid the duplication? > > 2. The following unit test fails consistently for me, when running all unit > > tests. It does pass when running individually. > > > > kafka.server.SimpleFetchTest > testReadFromLog FAILED > > junit.framework.AssertionFailedError: Counts should increment after > > fetch expected:<5> but was:<51432> > > at junit.framework.Assert.fail(Assert.java:47) > > at junit.framework.Assert.failNotEquals(Assert.java:277) > > at junit.framework.Assert.assertEquals(Assert.java:64) > > at junit.framework.Assert.assertEquals(Assert.java:130) > > at > > kafka.server.SimpleFetchTest.testReadFromLog(SimpleFetchTest.scala:145)
For (1) I noted this on the review but it is convenient to have the total under BrokerTopicMetrics as well which is a reasonable tradeoff since it only adds two additional meters. For (2) Aditya, can you look into that? - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review73020 ----------------------------------------------------------- On Feb. 17, 2015, 11:46 p.m., Aditya Auradkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30570/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 11:46 p.m.) > > > Review request for kafka and Joel Koshy. > > > Bugs: KAFKA-1914 > https://issues.apache.org/jira/browse/KAFKA-1914 > > > Repository: kafka > > > Description > ------- > > BrokerTopicStats changes to aggregate on a per-topic basis the total fetch > and produce requests > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaRequestHandler.scala > e4053fbe8ef78bf8bc39cb3f8ea4c21032613a16 > core/src/main/scala/kafka/server/ReplicaManager.scala > fb948b9ab28c516e81dab14dcbe211dcd99842b6 > core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala > ccf5e2e36260b2484181b81d1b06e81de972674b > > Diff: https://reviews.apache.org/r/30570/diff/ > > > Testing > ------- > > I've added asserts to the SimpleFetchTest to count the number of fetch > requests. I'm going to file an additional jira to add unit tests for all the > BrokerTopicMetrics updated via ReplicaManager > > > Thanks, > > Aditya Auradkar > >
