> On April 8, 2015, 9:56 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, line 794 > > <https://reviews.apache.org/r/31606/diff/2-3/?file=881937#file881937line794> > > > > "Default Partition: use the topic string as the key to determine the > > partition"
Yes, this is already implemented this way. If no partition is specified, then the topic string is used as the key to determine partition. > On April 8, 2015, 9:56 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala, lines 210-212 > > <https://reviews.apache.org/r/31606/diff/3/?file=906529#file906529line210> > > > > How about just calling TestUtils.sendMessages directly? I reverted my changes here, since Ewen introduced a new updateProducer() call in LogRecoveryTest everytime some messages are sent. - Flutra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/#review79438 ----------------------------------------------------------- On April 11, 2015, 1:36 a.m., Flutra Osmani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31606/ > ----------------------------------------------------------- > > (Updated April 11, 2015, 1:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1416 > https://issues.apache.org/jira/browse/KAFKA-1416 > > > Repository: kafka > > > Description > ------- > > Unified get and send messages in TestUtils.scala and its users > > changing sendMessages() signature from KafkaConfig to KafkaServer > > > KAFKA-1416 Unify sendMessages/getMessages in unit tests > > Unified get and send messages in TestUtils.scala and its users > > > Diffs > ----- > > > core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala > f3e76db5dcaaae9d301eb47bface83cc62ed87d6 > core/src/test/scala/unit/kafka/integration/FetcherTest.scala > 0dc837a402953c9c22578599a20db4cf271524cc > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > a1300894258c0ee77dffc96df24a2f7369eb68da > > core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala > ad66bb208b6d054784a5c81f82177b35036c3c14 > core/src/test/scala/unit/kafka/metrics/MetricsTest.scala > 247a6e947670090a4413af1357897ac440072db4 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 5a9e84d44f6567c3a01a4e068c751edb07ee9634 > > Diff: https://reviews.apache.org/r/31606/diff/ > > > Testing > ------- > > > Thanks, > > Flutra Osmani > >
