-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31606/#review79438
-----------------------------------------------------------



core/src/test/scala/unit/kafka/integration/FetcherTest.scala
<https://reviews.apache.org/r/31606/#comment128803>

    How about just calling TestUtils.sendMessages directly?



core/src/test/scala/unit/kafka/utils/TestUtils.scala
<https://reviews.apache.org/r/31606/#comment128806>

    "Default Partition: use the topic string as the key to determine the 
partition"



core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala
<https://reviews.apache.org/r/31606/#comment128799>

    How about just calling TestUtils.sendMessages directly?


- Guozhang Wang


On March 26, 2015, 7:21 a.m., Flutra Osmani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31606/
> -----------------------------------------------------------
> 
> (Updated March 26, 2015, 7:21 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1416
>     https://issues.apache.org/jira/browse/KAFKA-1416
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Unified get and send messages in TestUtils.scala and its users
> 
> 
> Diffs
> -----
> 
>   
> core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 
> 155fd046c9036b5b8b107bd21a8c6492c14644ea 
>   core/src/test/scala/unit/kafka/integration/FetcherTest.scala 
> 3093e459935ecf8e5b34fca34a422674562a7034 
>   core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala 
> 8342cae564ebc39fe74a512343a4523072ca205a 
>   
> core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala
>  3d0fc9deda2d3a39f2618a5be3edd98cd935ffbb 
>   core/src/test/scala/unit/kafka/metrics/MetricsTest.scala 
> 0f58ad8e698e3c0ec76c510bd5f76912a992209c 
>   core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 
> 92d6b2c672f74cdd526f2e98da8f7fb3696a88e3 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
> 1682a77362123449de6bb1d54a55887409990a24 
> 
> Diff: https://reviews.apache.org/r/31606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Flutra Osmani
> 
>

Reply via email to