> On March 25, 2015, 9:51 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/integration/FetcherTest.scala, line 85 > > <https://reviews.apache.org/r/31606/diff/2/?file=881933#file881933line85> > > > > Import TestUtils.sendMessages
It seems that this is a practice from all committers throughout the code: to use TestUtils.sendMessages() instead of importing it first. I tried it, but it is not recognized as a method from TestUtils. > On March 25, 2015, 9:51 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, lines 761-773 > > <https://reviews.apache.org/r/31606/diff/2/?file=881937#file881937line761> > > > > Compression code is no longer used anymore, which seems not correct? > > Flutra Osmani wrote: > The compression.codec is now set on sendMessages() > > Guozhang Wang wrote: > Isn't this function sendMessages()? Now when we call createProducer() we > will not pass in the props anymore and hence it will always use default > values, is that OK? We are still passing the producer properties in the createProducer() call. Not sure why this code diff snippet ommits it. The latest commit contains props in createProducer() call. - Flutra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/#review77804 ----------------------------------------------------------- On April 11, 2015, 1:36 a.m., Flutra Osmani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31606/ > ----------------------------------------------------------- > > (Updated April 11, 2015, 1:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1416 > https://issues.apache.org/jira/browse/KAFKA-1416 > > > Repository: kafka > > > Description > ------- > > Unified get and send messages in TestUtils.scala and its users > > changing sendMessages() signature from KafkaConfig to KafkaServer > > > KAFKA-1416 Unify sendMessages/getMessages in unit tests > > Unified get and send messages in TestUtils.scala and its users > > > Diffs > ----- > > > core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala > f3e76db5dcaaae9d301eb47bface83cc62ed87d6 > core/src/test/scala/unit/kafka/integration/FetcherTest.scala > 0dc837a402953c9c22578599a20db4cf271524cc > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > a1300894258c0ee77dffc96df24a2f7369eb68da > > core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala > ad66bb208b6d054784a5c81f82177b35036c3c14 > core/src/test/scala/unit/kafka/metrics/MetricsTest.scala > 247a6e947670090a4413af1357897ac440072db4 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 5a9e84d44f6567c3a01a4e068c751edb07ee9634 > > Diff: https://reviews.apache.org/r/31606/diff/ > > > Testing > ------- > > > Thanks, > > Flutra Osmani > >
