Hi Jun, On Tue, Jul 14, 2015 at 2:09 AM, Jun Rao <j...@confluent.io> wrote:
> Ismael, > > I followed the instructions in KAFKA-2320 and created a new Jenkins job ( > https://builds.apache.org/job/kafka-trunk-git-pr/). Could you check if it > works? > Thanks! It seems to be building when trunk changes as opposed to when PRs are submitted (eg https://github.com/apache/kafka/pull/74). I'll see if I can get some help from INFRA. As for wiki, I have a couple of minor comments. > > a. Could we add the following to the wiki? > To avoid conflicts, assign a jira to yourself if you plan to work on it. If > you are creating a jira and don't plan to work on it, leave the assignee as > Unassigned. > Good point, done. b. Previously, we mark a jira as "Patch Available" if there is a patch. > Could we reuse that instead of "In Progress" to be consistent? Also, if a > patch needs more work after review, the reviewer will mark the jira back to > "In Progress". > I added this as an additional step for the user because I don't think we can customise the behaviour of the pull request bot (which sets the status to "In Progress"). It's a bit redundant when a PR is created, so a bit annoying. I'll double-check with INFRA. I also mentioned in the review section about the reviewer changing the JIRA status back to "In Progress". Best, Ismael