> On July 24, 2015, 5:01 p.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 264 > > <https://reviews.apache.org/r/36652/diff/3/?file=1020607#file1020607line264> > > > > Hi Jun, > > Cleaning up in finally is actually nice. I will make the necessary > > change and upload a new patch. > > > > I was looking at the patch for : > > https://issues.apache.org/jira/browse/KAFKA-2353 > > as per the suggestions on the jira ticket. > > > > Was just curious if we can do the same there as well. We are catching > > all the Throwables and allowing the thread to continue processing. Is there > > something I am missing here.
Mayuresh, Yes, saw the changes in KAFKA-2353. We can leave this the way that you did for now and revisit the catch throwable issue later. - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review92928 ----------------------------------------------------------- On July 24, 2015, 4:36 a.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36652/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 4:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2351 > https://issues.apache.org/jira/browse/KAFKA-2351 > > > Repository: kafka > > > Description > ------- > > Added a try-catch to catch any exceptions thrown by the nioSelector > > > Addressed comments on the Jira ticket > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 91319fa010b140cca632e5fa8050509bd2295fc9 > > Diff: https://reviews.apache.org/r/36652/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
