----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review95868 -----------------------------------------------------------
core/src/main/scala/kafka/network/SocketServer.scala (line 264) <https://reviews.apache.org/r/36652/#comment151020> I referred this : https://www.sumologic.com/2014/05/05/why-you-should-never-catch-throwable-in-scala/ from the kafka 2353 patch. http://www.tzavellas.com/techblog/2010/09/20/catching-throwable-in-scala/ - Mayuresh Gharat On Aug. 13, 2015, 8:10 p.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36652/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 8:10 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2351 > https://issues.apache.org/jira/browse/KAFKA-2351 > > > Repository: kafka > > > Description > ------- > > Added a try-catch to catch any exceptions thrown by the nioSelector > > > Addressed comments on the Jira ticket > > > Addressed Jun's comments > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > dbe784b63817fd94e1593136926db17fac6fa3d7 > > Diff: https://reviews.apache.org/r/36652/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
