> On Aug. 21, 2015, 6:14 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 264 > > <https://reviews.apache.org/r/36652/diff/4/?file=1039545#file1039545line264> > > > > Yes that's exactly what we need. Any reason why we shouldn't use > > `NonFatal` as is? i.e., if we hit VM errors such as those in `NonFatal` > > then we should probably let it propagate anyway. Can you file a jira to do > > this across the board?
There have been a few cases where we wanted to catch some fatal errors too (in `SocketServer`, if I remember correctly). In many (most?) cases `NonFatal` is probably OK though. Sure, I'll file a JIRA. - Ismael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review96069 ----------------------------------------------------------- On Aug. 13, 2015, 8:10 p.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36652/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 8:10 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2351 > https://issues.apache.org/jira/browse/KAFKA-2351 > > > Repository: kafka > > > Description > ------- > > Added a try-catch to catch any exceptions thrown by the nioSelector > > > Addressed comments on the Jira ticket > > > Addressed Jun's comments > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > dbe784b63817fd94e1593136926db17fac6fa3d7 > > Diff: https://reviews.apache.org/r/36652/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
