[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660276#comment-14660276
]
Mayuresh Gharat commented on KAFKA-2120:
----------------------------------------
[~jasong35] I am not too familiar with the consumer code right now. From your
comment above I get a feeling that the consumer and producer have different
requirements. Also I see that consumer uses a ConsumerNetworkClient and we can
have a separate timeout config for Consumer that can be passed to
NetworkClient.
By per-requests timeout, do you mean that different types of request can have
different timeouts configured? If yes, it can be done. But then we might
degrade the user experience wherein the user has to now configure different
timeouts for different kinds of requests, which means that he has to have
internal knowledge of different kinds of requests that clients are making to
brokers.
I might be wrong here since I am not fully aware of the consumer code base and
I am still starting with it. Let me know your thoughts on this.
> Add a request timeout to NetworkClient
> --------------------------------------
>
> Key: KAFKA-2120
> URL: https://issues.apache.org/jira/browse/KAFKA-2120
> Project: Kafka
> Issue Type: New Feature
> Reporter: Jiangjie Qin
> Assignee: Mayuresh Gharat
> Fix For: 0.8.3
>
> Attachments: KAFKA-2120.patch, KAFKA-2120_2015-07-27_15:31:19.patch,
> KAFKA-2120_2015-07-29_15:57:02.patch
>
>
> Currently NetworkClient does not have a timeout setting for requests. So if
> no response is received for a request due to reasons such as broker is down,
> the request will never be completed.
> Request timeout will also be used as implicit timeout for some methods such
> as KafkaProducer.flush() and kafkaProducer.close().
> KIP-19 is created for this public interface change.
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+timeout+to+NetworkClient
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
