[ 
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660375#comment-14660375
 ] 

Jiangjie Qin commented on KAFKA-2120:
-------------------------------------

[~hachikuji] [~mgharat], the request time is for exception handling purpose, 
the request timeout should be the highest timeout across all the timeout. Can 
we just sanity check the configurations user provides? The rules should be:
Request timeout > session timeout.
Request timeout > fetch.max.wait.timeout
request timeout won't kick in before the other timeout reached.
The sanity check patch should be relatively simple. We can either do it in this 
patch or in a separate patch.

> Add a request timeout to NetworkClient
> --------------------------------------
>
>                 Key: KAFKA-2120
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2120
>             Project: Kafka
>          Issue Type: New Feature
>            Reporter: Jiangjie Qin
>            Assignee: Mayuresh Gharat
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-2120.patch, KAFKA-2120_2015-07-27_15:31:19.patch, 
> KAFKA-2120_2015-07-29_15:57:02.patch
>
>
> Currently NetworkClient does not have a timeout setting for requests. So if 
> no response is received for a request due to reasons such as broker is down, 
> the request will never be completed.
> Request timeout will also be used as implicit timeout for some methods such 
> as KafkaProducer.flush() and kafkaProducer.close().
> KIP-19 is created for this public interface change.
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+timeout+to+NetworkClient



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to