[ 
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660405#comment-14660405
 ] 

Jason Gustafson commented on KAFKA-2120:
----------------------------------------

[~becket_qin] That is what I was thinking when I first looked at this patch, 
and it's still an option. However, since we are recommending session timeouts 
on the order of 60 seconds, it seems unfortunate to have to apply the same 
timeout on all requests (even those that should return immediately). Allowing a 
lower timeout for other requests means that the consumer could recover from 
worst-case failures much quicker. That being said, since the sanity check is 
easy, I think it's a good idea to add it to this patch.

> Add a request timeout to NetworkClient
> --------------------------------------
>
>                 Key: KAFKA-2120
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2120
>             Project: Kafka
>          Issue Type: New Feature
>            Reporter: Jiangjie Qin
>            Assignee: Mayuresh Gharat
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-2120.patch, KAFKA-2120_2015-07-27_15:31:19.patch, 
> KAFKA-2120_2015-07-29_15:57:02.patch
>
>
> Currently NetworkClient does not have a timeout setting for requests. So if 
> no response is received for a request due to reasons such as broker is down, 
> the request will never be completed.
> Request timeout will also be used as implicit timeout for some methods such 
> as KafkaProducer.flush() and kafkaProducer.close().
> KIP-19 is created for this public interface change.
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+timeout+to+NetworkClient



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to