[
https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709640#comment-14709640
]
Jiangjie Qin commented on KAFKA-2389:
-------------------------------------
[~ewencp] I am modifying the code and found it is actually uglier than I
initially thought to ask user to call commitAsync(null, callback) - which is
the case [~hachikuji] mentioned. So I am with Jason that we'd better support
all the three variants. My current pull request is following this approach.
> CommitType seems not necessary in commit().
> -------------------------------------------
>
> Key: KAFKA-2389
> URL: https://issues.apache.org/jira/browse/KAFKA-2389
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
>
> The CommitType does not seem to be necessary in for commit(), it can be
> inferred from whether user passed in a callback or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
