[
https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715846#comment-14715846
]
Guozhang Wang commented on KAFKA-2389:
--------------------------------------
Yeah, I did not think that Zookeeper API is the golden standard and we should
just align with it, I guess I am just subjectively leaning towards the same
function names for sync / async since for sync methods users can always put
their callback logic after the commit() call hence they do not need a callback
parameter, and wanted to use Zookeeper API as a backing point. Regarding
[~becket_qin]'s point I agree that would be the issue. Anyways since this is
pure personal taste I am willing to go with the majority vote.
> CommitType seems not necessary in commit().
> -------------------------------------------
>
> Key: KAFKA-2389
> URL: https://issues.apache.org/jira/browse/KAFKA-2389
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
>
> The CommitType does not seem to be necessary in for commit(), it can be
> inferred from whether user passed in a callback or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
