[
https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715660#comment-14715660
]
Jiangjie Qin commented on KAFKA-2389:
-------------------------------------
[~guozhang] As you said, distinguishing sync/async with callback is intuitive
and that was also my original proposal. One caveat of this, though, is we will
have commit(Map) and commit(OffsetCommitCallback), so user cannot simply call
commit(null), instead they have to call commit((OffsetCommitCallback) null).
The casting is a little bit ugly. Naming the sync/async separately solves this
problem.
> CommitType seems not necessary in commit().
> -------------------------------------------
>
> Key: KAFKA-2389
> URL: https://issues.apache.org/jira/browse/KAFKA-2389
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
>
> The CommitType does not seem to be necessary in for commit(), it can be
> inferred from whether user passed in a callback or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
