Hi,
Thank you all for having a look!
The KIP is now updated with the result of these late discussions, though I did
take some liberty with this part:
- If the "compaction.strategy.header" configuration is not set (or is
blank), then the compaction strategy will fallback to "offset";
Alternatively, we can also set it to be a mandatory property when the strategy
is "header" and fail the application to start via a config validation (I would
honestly prefer this, but its up to your taste).
Anyway, this is now a minute detail that can be adapted during the final stage
of this KIP, so are you all alright with me changing the status to [ACCEPTED]?
Cheers,
Luis
On Thursday, June 28, 2018, 2:08:11 PM GMT+2, Ted Yu <[email protected]>
wrote:
+1
On Thu, Jun 28, 2018 at 4:56 AM, Luís Cabral <[email protected]>
wrote:
> Hi Ted,
> Can I also get your input on this?
>
> bq. +1 from my side for using `compaction.strategy` with values
> "offset","timestamp" and "header" and `compaction.strategy.header`
> -Matthias
>
> bq. +1 from me as well.
> -Guozhang
>
>
> Cheers,
> Luis
>
>
>
