Hi Jun and Joel, The KIP writeup has changed by quite a bit since your +1. Can you please take another review? Thanks a lot for your time!
Lucas On Tue, Jul 17, 2018 at 10:33 AM, Joel Koshy <jjkosh...@gmail.com> wrote: > +1 on the KIP. > > (I'm not sure we actually necessary to introduce the condition variables > for the concern that Jun raised, but it's an implementation detail that we > can defer to a discussion in the PR.) > > On Sat, Jul 14, 2018 at 10:45 PM, Lucas Wang <lucasatu...@gmail.com> > wrote: > > > Hi Jun, > > > > I agree by using the conditional variables, there is no need to add such > a > > new config. > > Also thanks for approving this KIP. > > > > Lucas > > >
