As per our discussion in Zulip. I've created branches called 'quarkus-3.2LTS' in - incubator-kie-kogito-pipelines - incubator-kie-drools - incubator-kie-kogito-runtimes - incubator-kie-kogito-apps - incubator-kie-kogito-examples
Together with that I adjusted pipeline configuration so that we have nightly builds for this branch, the job generation is in progress. Hopefully tomorrow we'll have our first results. For PR checks, we'll be in a bit of an odd situation, where PRs against branch 'quarkus-3.2LTS' would be handled by PR checks for main. It should work for now, a better solution would require refactoring, which is not feasible at the moment - already too many things changing/pending merge. In case of issues in PR checks we'll need to adjust. Regards Jan On Thu, 30 Nov 2023 at 14:14, Pere Fernandez (apache) <[email protected]> wrote: > Great, > > I just sent a PR to migrate kogito-apps to Quarkus 3.2 LTS (3.2.9.Final): > > https://github.com/apache/incubator-kie-kogito-apps/pull/1929 > > Cheers! > > On Thu, 30 Nov 2023 at 11:34, Toshiya Kobayashi < > [email protected]> > wrote: > > > Hello guys, > > > > Now we have 3 PRs for Quarkus 3.2 LTS (3.2.9.Final) > > > > https://github.com/apache/incubator-kie-drools/pull/5596 > > https://github.com/apache/incubator-kie-kogito-runtimes/pull/3296 > > https://github.com/apache/incubator-kie-kogito-examples/pull/1834 > > > > These 3 PRs compile successfully, but have several test failures in > > kogito-runtimes and kogito-examples. > > > > Please have a look at the chat ( > > > > > https://kie.zulipchat.com/#narrow/stream/381961-drools-dev/topic/Quarkus.203.20migration/near/405030861 > > ) > > and help solve issues, thanks! > > > > Toshiya > > > > On Wed, Nov 29, 2023 at 3:10 AM Jakub Grabowski < > [email protected] > > > > > wrote: > > > > > Hi All, > > > > > > I've just joined this group after Jason Porter's information about this > > > topic on Zulipchat. > > > I described my concerns regarding Kogito still running on EOLed Quarkus > > > 2.16. > > > It's good to see that things are moving forward. > > > As I mentioned on Zulip, I could spare some time to test the Drools > part > > on > > > my real-life projects already using Kogito Drools in many modules. > > > > > > +1 for the idea to stick to LTS version > > > >= Java 17 also seems a reasonable choice > > > > > > Regards, > > > Jakub Grabowski. > > > > > > wt., 28 lis 2023 o 03:46 Toshiya Kobayashi <[email protected] > > > > > napisał(a): > > > > > > > Thank you all for the replies. > > > > > > > > To recap discussed-points: > > > > > > > > * Java version > > > > > > > > Agreed on Java 17. > > > > > > > > It will be configured in > > > > https://github.com/apache/incubator-kie-kogito-pipelines/pull/1125 > > Thank > > > > you, Jan and Tibor! > > > > > > > > * Quarkus version > > > > > > > > Tibor, Alex and Jason give +1 for LTS 3.2. > > > > > > > > Mario, WDYT? > > > > > > > > A) Complete Quarkus 3.5.2 migration anyway. After the migration > done, > > > > create a Quarkus 3.2 LTS branch, too. > > > > B) Recreate the current migration PRs to meet Quarkus 3.2. > > > > > > > > * Maven version > > > > > > > > Alex gave +1 for 3.9.3 (= proposed-maven-version of Quarkus > > 3.2.9.Final). > > > > > > > > Mario mentioned that it can be upgraded after the migration. > > > > > > > > * Spring Boot version > > > > > > > > Pere, sorry that I'm not well understanding the reply. You meant it's > > > okay > > > > to go with `3.0.5` for now, or any higher version than `3.0.5` in > mind? > > > > > > > > Mario mentioned that it can be upgraded after the migration. > > > > > > > > Regards, > > > > Toshiya > > > > > > > > On Tue, Nov 28, 2023 at 12:06 AM Alex Porcelli <[email protected]> > > wrote: > > > > > > > > > +1 for Java 17 > > > > > -1 for current Quarkus 3.5.2, as expressed earlier I think LTS > > (3.2.9) > > > > > would be better > > > > > +1 for Maven upgrade to 3.9.3 (aligns with Quarkus LTS 3.2.9) > > > > > - 0 neutral for SpringBoot upgrades. As pointed out by Pere, it's > not > > > > > a bad idea to try to upgrade SB, but at the same time I don't think > > > > > this is a blocker. > > > > > > > > > > On Mon, Nov 27, 2023 at 7:26 AM Pere Fernandez (apache) > > > > > <[email protected]> wrote: > > > > > > > > > > > > Hi Toshiya, thank you for the recap! > > > > > > > > > > > > Regarding the Spring-boot version, I'd prefer to continue with > the > > > > > version > > > > > > upgrade since most of the recipes/patches already include some > > > changes > > > > > > related to Spring-boot (at least in kogito-runtimes, kogito-apps > & > > > > > > kogito-examples), so I think that since we have some work already > > > done > > > > > it's > > > > > > great to move the upgrade forward. > > > > > > > > > > > > However, I think that it would be good to do a check to all our > > > Spring > > > > > Boot > > > > > > stack at some point after the upgrade, last week I tried some > > > > SpringBoot > > > > > > examples and were presenting issues, I couldn't look deeply so > IDK > > if > > > > the > > > > > > errors were about misconfiguration or bugs in our codebase. > > > > > > > > > > > > Cheers! > > > > > > > > > > > > On Mon, 27 Nov 2023 at 09:31, Tibor Zimányi <[email protected] > > > > > > wrote: > > > > > > > > > > > > > Hi Mario, > > > > > > > > > > > > > > based on this I think the CI is already using Java 17 (1). If > > that > > > is > > > > > not > > > > > > > the case I could take a look. > > > > > > > > > > > > > > As far as Java 17 I agree we should target Java 17. Recently > even > > > > > newer LTS > > > > > > > Java was released (21) so I think 17 is fine. > > > > > > > > > > > > > > Best regards, > > > > > > > Tibor > > > > > > > > > > > > > > (1) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-kie-kogito-pipelines/blob/main/apache-nodes/Dockerfile.kogito-ci-build#L5 > > > > > > > > > > > > > > > > > > > > > Dňa po 27. 11. 2023, 9:05 Mario Fusco <[email protected]> > > > > > napísal(a): > > > > > > > > > > > > > > > Thanks for the recap of the situation Toshiya, > > > > > > > > > > > > > > > > I was struggling trying to make kogito-runtimes to work with > > Java > > > > > 11, but > > > > > > > > at this point this seems to be a wasteful effort if we decide > > to > > > go > > > > > with > > > > > > > 17 > > > > > > > > as I also warmly suggest. > > > > > > > > > > > > > > > > If there is anybody who thinks that moving to Java 17 is not > a > > > good > > > > > idea, > > > > > > > > please let us know immediately. > > > > > > > > > > > > > > > > Also is there anybody who could migrate the CI to Java 17? > I'd > > > > really > > > > > > > > appreciate an help on this. > > > > > > > > > > > > > > > > As for the other 2 points (maven and spring-boot versions) I > > > would > > > > > avoid > > > > > > > > having too many moving parts at this stage, so if version > 3.8.7 > > > for > > > > > maven > > > > > > > > and 3.0.5 for spring-boot are good enough I'd stick with them > > at > > > > > least > > > > > > > for > > > > > > > > now. We will have time to upgrade them after this migration > > will > > > be > > > > > > > > finalized. > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Mario > > > > > > > > > > > > > > > > On 2023/11/27 05:51:29 Toshiya Kobayashi wrote: > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > We'd like to clarify some points for the migration. > > > > > > > > > > > > > > > > > > 1) Java version > > > > > > > > > > > > > > > > > > In the zulip chat, we discussed that we would like to use > > Java > > > 17 > > > > > for > > > > > > > the > > > > > > > > > minimal version for Quarkus 3.5.2 migration. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://kie.zulipchat.com/#narrow/stream/381961-drools-dev/topic/Quarkus.203.20migration/near/403922014 > > > > > > > > > > > > > > > > > > If we have Java 17 as the minimal version, we don't have to > > > > > downgrade > > > > > > > the > > > > > > > > > quarkus-camel (3.0.0-M1 -> 2.15.0) and spring-boot (3.0.5 > -> > > > > 2.6.6) > > > > > > > > > versions. > > > > > > > > > > > > > > > > > > Do we agree on Java 17 as the minimal version? > > > > > > > > > > > > > > > > > > 2) Maven version > > > > > > > > > > > > > > > > > > This may not be very important. > > > > > > > > > > > > > > > > > > Quarkus 3.5.2 supports "[3.8.2,)" > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/quarkusio/quarkus/blob/3.5.2/build-parent/pom.xml#L62 > > > > > > > > > > > > > > > > > > and recommneds "3.9.5" > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/quarkusio/quarkus/blob/3.5.2/build-parent/pom.xml#L65 > > > > > > > > > > > > > > > > > > Probably "3.9.5" would be nice, but supportable versions > > would > > > be > > > > > > > fine. I > > > > > > > > > just wanted to note here. > > > > > > > > > > > > > > > > > > 2) How to specify Java version in Jenkins CI (at the > moment, > > > for > > > > > PR. > > > > > > > But > > > > > > > > > others too) > > > > > > > > > > > > > > > > > > Can we specify the Jenkins Java version at the > > kogito-runtimes > > > > > side? > > > > > > > > > > > > > > > > > > Sorry, I'm not just knowledgeable about it. I tested > > > > > "BUILD_JDK_TOOL" > > > > > > > in > > > > > > > > > `.ci/jenkins/Jenkinsfile`, but I cannot even confirm if > it's > > > > > effective. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-kie-kogito-runtimes/pull/3292/files#diff-cc7fa003f07626ab6b3e955a24d87913c05aee8bb6c56fc05bf243f617fac962R21 > > > > > > > > > > > > > > > > > > Please kindly share the right way to specify that. > > > > > > > > > > > > > > > > > > 3) Spring Boot version > > > > > > > > > > > > > > > > > > Pere mentioned > > > > > > > > > > > > > > > > > > > my guts say that we should upgrade if we have the > > oportunity > > > > but > > > > > I'm > > > > > > > > > affraid it could add more pain. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://kie.zulipchat.com/#narrow/stream/381961-drools-dev/topic/Quarkus.203.20migration/near/403970518 > > > > > > > > > > > > > > > > > > Do we want to upgrade spring-boot higher than 3.0.5? > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > Toshiya > > > > > > > > > > > > > > > > > > On Thu, Nov 23, 2023 at 6:36 PM Mario Fusco < > > > > [email protected] > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > It would be best to agree on a branch name - if it's > > > quarkus3 > > > > > - and > > > > > > > > > > > generate special pipelines for that branch. So that we > > have > > > > > clear > > > > > > > > > > > separation. It would require branching of whole groups > of > > > > > > > > repositories > > > > > > > > > > > (similarly as above - incubator-kie-kogito-apps and > > > others). > > > > > > > > > > > > > > > > > > > > Hi Jan, > > > > > > > > > > > > > > > > > > > > I agree on this. For now I replaced Toshiya's PR and now > I > > > have > > > > > 2 PRs > > > > > > > > with > > > > > > > > > > same branch name so CI could at least run against them, > > see: > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-kie-drools/pull/5589 > > > > > > > > > > > > > > > https://github.com/apache/incubator-kie-kogito-runtimes/pull/3291 > > > > > > > > > > > > > > > > > > > > CI is still running, anyway Drools should be ok (or if it > > > > isn't I > > > > > > > will > > > > > > > > > > take care of it), while kogito-runtimes is finally > > compiling, > > > > but > > > > > > > > locally I > > > > > > > > > > have the 2 test failures that I'm pasting at the end of > > this > > > > > email. > > > > > > > I'm > > > > > > > > > > working on them, but in all honest I have zero knowledge > of > > > > that > > > > > > > area, > > > > > > > > so I > > > > > > > > > > would really appreciate any help on them. > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > Mario > > > > > > > > > > > > > > > > > > > > [ERROR] Failed to execute goal > > > > > > > > > > > org.apache.maven.plugins:maven-failsafe-plugin:3.1.2:verify > > > > > > > > > > (integration-test) on project > > > > > > > > > > kogito-quarkus-serverless-workflow-integration-test: > There > > > are > > > > > test > > > > > > > > > > failures. > > > > > > > > > > > > > > > > > > > > [ERROR] Failures: > > > > > > > > > > [ERROR] EventTimedoutIT.testTimedout:94 > > > > > > > > > > expected: 0L > > > > > > > > > > but was: 1L > > > > > > > > > > [ERROR] ForEachRestIT.testForEachSubflow:62 1 > expectation > > > > > failed. > > > > > > > > > > Expected status code <201> but was <400>. > > > > > > > > > > > > > > > > > > > > [ERROR] Errors: > > > > > > > > > > [ERROR] > > > > > CallbackStateTimeoutsIT.callbackStateTimeoutsExceeded:60 » > > > > > > > > > > ConditionTimeout Assertion condition defined as a > > > > > > > > > > org.kie.kogito.test.utils.ProcessInstancesRESTTestUtils 1 > > > > > expectation > > > > > > > > > > failed. > > > > > > > > > > Expected status code <404> but was <200>. > > > > > > > > > > within 10 seconds. > > > > > > > > > > [ERROR] > > > > > > > > > > > > > > > > > > > > > > > > > > > CallbackStateWithTimeoutsErrorHandlerIT.callbackStateTimeoutsExceeded:72 > > > > > > > » > > > > > > > > > > ConditionTimeout Assertion condition defined as a > > > > > > > > > > org.kie.kogito.test.utils.ProcessInstancesRESTTestUtils 1 > > > > > expectation > > > > > > > > > > failed. > > > > > > > > > > Expected status code <404> but was <200>. > > > > > > > > > > within 10 seconds. > > > > > > > > > > [INFO] > > > > > > > > > > [ERROR] Tests run: 79, Failures: 2, Errors: 2, Skipped: 0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > > > To unsubscribe, e-mail: [email protected] > > > > > > > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > To unsubscribe, e-mail: [email protected] > > > > > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: [email protected] > > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > > > > > > >
