[
https://issues.apache.org/jira/browse/KNOX-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007520#comment-16007520
]
Larry McCay commented on KNOX-928:
----------------------------------
Thanks for the handling of the missing topology, [~moresandeep].
This looks like solid work and I look forward to playing around with it!
Some additional review comments - basically a rebase seems to be needed and a
handful of nits:
* It seems that there is a merge issue with GatewayTestConfig where you have
removed a method that I just added getHeaderNameForRemoteAddress
* GatewayFilter and test classes are also missing changes from the same commit
- perhaps you need to rebase again
* javadoc style comments make it harder to read and distinguish blocks of logic
from new methods - I prefer //'s instead
* @since tags are not consistently used across the project and should probably
be avoided - especially since 0.13.0 may end up being 1.0.0
* GatewayBasicFuncTest has a debug System.out.println uncommented that used to
be commented - we should avoid plain println's
> Topology Port Mapping
> ---------------------
>
> Key: KNOX-928
> URL: https://issues.apache.org/jira/browse/KNOX-928
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Reporter: Sandeep More
> Assignee: Sandeep More
> Labels: KIP-6
> Fix For: 0.13.0
>
> Attachments: KNOX-928.001.patch, KNOX-928.002.patch
>
>
> Instead of having a single "default topology" we can map topologies to
> specific ports and have a dedicated URL without the gateway specific app
> context.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
