[ 
https://issues.apache.org/jira/browse/KNOX-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018648#comment-16018648
 ] 

Larry McCay commented on KNOX-928:
----------------------------------

Feature is working well!

A couple remaining nits:

* the following warning/error needs to have a bit more information
2017-05-20 19:44:05,053 ERROR hadoop.gateway 
(GatewayServer.java:checkMappedTopologiesExist(655)) -  Could not find topology 
"token" configured in gateway-config.xml. 

It should indicate the port that is mapped to the "token" topology and also 
that the invalid mapping will b ignored and will require a server restart even 
if the missing topology is added.

* javadoc style comments within the body of methods should be replaced with 
slashes except where the level of docs hint at requiring methods to be 
extracted from the existing method.
* @since tags should be removed as mentioned before they aren't consistently 
used and 0.13.0 may end up being 1.0.0 and they would also need to be managed 
when backported to previous release lines if needed.

If you would like to commit this now and clean up those nitpicks in a follow up 
JIRA I would good with that.

+1

> Topology Port Mapping
> ---------------------
>
>                 Key: KNOX-928
>                 URL: https://issues.apache.org/jira/browse/KNOX-928
>             Project: Apache Knox
>          Issue Type: New Feature
>          Components: Server
>            Reporter: Sandeep More
>            Assignee: Sandeep More
>              Labels: KIP-6
>             Fix For: 0.13.0
>
>         Attachments: KNOX-928.001.patch, KNOX-928.002.patch, 
> KNOX-928.003.patch, KNOX-928.004.patch
>
>
> Instead of having a single "default topology" we can map topologies to
> specific ports and have a dedicated URL without the gateway specific app
> context.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to