Awesome, thanks, Sandor! I'll spin that up today and get the new VOTE up. On Wed, Apr 22, 2020 at 7:53 AM Sandor Molnar <smol...@cloudera.com.invalid> wrote:
> Hi Larry, > > I managed to have both JIRAs fixed on the v1.4.0 branch. See Git's log > since RC2: > > commit 48b6e84f7edbfdd5838a4e28762bd5f8471534ae (*HEAD -> **v1.4.0*, > *upstream/v1.4.0*) > > Author: Sandor Molnar <smol...@apache.org> > > Date: Wed Apr 22 13:35:00 2020 +0200 > > > KNOX-2350 - Handling event types w/o COMMAND and/or COMMAND_STATUS > attributes when polling CM events (#318) (#319) > > > commit 60bb44d1bacebca6e362f58c5e754e66b5586a3e > > Author: Sandor Molnar <smol...@apache.org> > > Date: Wed Apr 22 10:59:28 2020 +0200 > > > KNOX-2353 - Disabled CM descriptor monitoring and advanced service > discovery changes monitoring by default (#320) > > > commit 9634a3ed4ab06f2aaf7bb2acbc2ea721717efbc4 > > Author: Kevin Risden <risd...@users.noreply.github.com> > > Date: Mon Apr 20 12:29:04 2020 -0400 > > > KNOX-2347 - Disable shellcheck for github actions (#317) > > > > Signed-off-by: Kevin Risden <kris...@apache.org> > > > commit 2069f9511d8ac2d3d5572db3ee24a46a436829f3 (*tag: v1.4.0-rc2*) > > Author: lmccay <lmc...@apache.org> > > Date: Sun Apr 19 13:46:08 2020 -0400 > > > KNOX-2345 - KnoxShellTable must handle NULL cols > > I think it should be OK to spin RC3 based on this state. > > Cheers, > Sandor > > On Tue, Apr 21, 2020 at 8:44 PM Sandor Molnar <smol...@cloudera.com> > wrote: > > > I've just filed a JIRA: https://issues.apache.org/jira/browse/KNOX-2353 > > > > On Tue, Apr 21, 2020 at 5:47 PM Phil Zampino <pzamp...@apache.org> > wrote: > > > >> +1 > >> > >> On Tue, Apr 21, 2020 at 11:43 AM larry mccay <larry.mc...@gmail.com> > >> wrote: > >> > >> > I would say that the renaming to be more generic can wait until the > next > >> > release. > >> > Especially, if we disable it out of the box for this release. > >> > > >> > > >> > On Tue, Apr 21, 2020 at 11:26 AM Phil Zampino <pzamp...@apache.org> > >> wrote: > >> > > >> > > Should we take care of > >> https://issues.apache.org/jira/browse/KNOX-2344 > >> > > also/instead < > >> > https://issues.apache.org/jira/browse/KNOX-2344also/instead> > >> > > ? > >> > > > >> > > On Tue, Apr 21, 2020 at 11:05 AM larry mccay <lmc...@apache.org> > >> wrote: > >> > > > >> > > > Folks - > >> > > > > >> > > > Should we take this opportunity to address any of the issues we > >> decided > >> > > > were not blockers? > >> > > > For instance, should we disable the CM monitor out of the box? > >> > > > > >> > > > thanks, > >> > > > > >> > > > --larry > >> > > > > >> > > > On Tue, Apr 21, 2020 at 10:42 AM Sandor Molnar > >> > > > <smol...@cloudera.com.invalid> > >> > > > wrote: > >> > > > > >> > > > > I committed PR #318 (where the target is the master branch) 30 > >> > minutes > >> > > > ago. > >> > > > > I've just created another one for branch v1.4.0 here: > >> > > > > https://github.com/apache/knox/pull/319 > >> > > > > Once all checks are completed I'm going to merge it too and you > >> can > >> > > spin > >> > > > > RC3. > >> > > > > > >> > > > > Sandor > >> > > > > > >> > > > > On Tue, Apr 21, 2020 at 4:27 PM larry mccay <lmc...@apache.org> > >> > wrote: > >> > > > > > >> > > > > > Agreed. > >> > > > > > I will cancel the VOTE on RC2 now and will wait for the PR to > be > >> > > > > committed > >> > > > > > to spin RC 3. > >> > > > > > > >> > > > > > -1 > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > On Tue, Apr 21, 2020 at 9:56 AM Phil Zampino < > >> pzamp...@apache.org> > >> > > > > wrote: > >> > > > > > > >> > > > > > > I agree that this is a serious defect. Serious enough to > merit > >> > > > another > >> > > > > > RC. > >> > > > > > > > >> > > > > > > On Tue, Apr 21, 2020 at 9:53 AM Sandor Molnar > >> > > > > > <smol...@cloudera.com.invalid > >> > > > > > > > > >> > > > > > > wrote: > >> > > > > > > > >> > > > > > > > Hi folks, > >> > > > > > > > > >> > > > > > > > yesterday I found a bug in CM configuration monitor that > is > >> > quite > >> > > > > easy > >> > > > > > to > >> > > > > > > > reproduce and makes the entire feature broken. A JIRA was > >> filed > >> > > and > >> > > > > the > >> > > > > > > PR > >> > > > > > > > is under review now: > >> > > > > > > > https://issues.apache.org/jira/browse/KNOX-2350 > >> > > > > > > > https://github.com/apache/knox/pull/318 > >> > > > > > > > > >> > > > > > > > Since CM related changes are a significant part of this > >> release > >> > > I'm > >> > > > > > > > wondering if we should call out Knox 1.4.0 - RC3 with that > >> fix > >> > > > > > included. > >> > > > > > > > > >> > > > > > > > Any objections? > >> > > > > > > > > >> > > > > > > > Cheers, > >> > > > > > > > Sandor > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > On Mon, Apr 20, 2020 at 11:14 PM Sandeep Moré < > >> > > > moresand...@gmail.com > >> > > > > > > >> > > > > > > > wrote: > >> > > > > > > > > >> > > > > > > > > +1 > >> > > > > > > > > > >> > > > > > > > > Found couple of issues in knoxcli while testing this > >> release. > >> > > > > > > > > Both of these bugs, KNOX-2315 > >> > > > > > > > > <https://issues.apache.org/jira/browse/KNOX-2315> and > >> > > KNOX-2349 > >> > > > > > > > > <https://issues.apache.org/jira/browse/KNOX-2349> are > >> not a > >> > > > > > regression > >> > > > > > > > so > >> > > > > > > > > we can move ahead with the release. > >> > > > > > > > > > >> > > > > > > > > Checked: > >> > > > > > > > > * Downloaded and built from source > >> > > > > > > > > * Checked LICENSE and NOTICE files > >> > > > > > > > > * Verified GPG/SHA signatures for Knox source, Knox and > >> > > Knoxshell > >> > > > > > > release > >> > > > > > > > > packages > >> > > > > > > > > * Installed pseudo-distributed instance (Mac OS X ) > >> > > > > > > > > * Checked Zeppelin > >> > > > > > > > > * Checked CM Service Discovery with kerberos auth > >> > > > > > > > > * Checked remote alias service with kerberos auth > >> > (encountered > >> > > > > > > KNOX-2315 > >> > > > > > > > > <https://issues.apache.org/jira/browse/KNOX-2315>) > >> > > > > > > > > * Checked knoxcli command to convert topologies to > >> providers > >> > > and > >> > > > > > > > > descriptors (encountered KNOX-2349 > >> > > > > > > > > <https://issues.apache.org/jira/browse/KNOX-2349>) > >> > > > > > > > > > >> > > > > > > > > Best, > >> > > > > > > > > Sandeep > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > On Sun, Apr 19, 2020 at 4:27 PM larry mccay < > >> > > > larry.mc...@gmail.com > >> > > > > > > >> > > > > > > > wrote: > >> > > > > > > > > > >> > > > > > > > > > All - > >> > > > > > > > > > > >> > > > > > > > > > A 2nd candidate for the Apache Knox 1.4.0 release is > >> > > available > >> > > > > at: > >> > > > > > > > > > > >> > > > > > > > > > > https://dist.apache.org/repos/dist/dev/knox/knox-1.4.0/ > >> > > > > > > > > > > >> > > > > > > > > > The release candidate is a zip archive of the sources > >> in: > >> > > > > > > > > > > >> > > > > > > > > > https://https://gitbox.apache.org/repos/asf/knox.git > >> > > > > > > > > > Branch v1.4.0 (git checkout -b v1.4.0) > >> > > > > > > > > > > >> > > > > > > > > > The KEYS file for signature validation is available > at: > >> > > > > > > > > > https://dist.apache.org/repos/dist/release/knox/KEYS > >> > > > > > > > > > > >> > > > > > > > > > To assist in testing the knoxshell features you can > find > >> > the > >> > > > new > >> > > > > > > > > KnoxShell > >> > > > > > > > > > User Guide at > >> > > > > > > > > > > >> > > > > > http://knox.apache.org/books/knox-1-4-0/knoxshell_user_guide.html > >> > > > > > > > > > > >> > > > > > > > > > Gateway User Guide: > >> > > > > > > > > > > http://knox.apache.org/books/knox-1-4-0/user-guide.html > >> > > > > > > > > > > >> > > > > > > > > > Dev Guide: > >> > > > > http://knox.apache.org/books/knox-1-4-0/dev-guide.html > >> > > > > > > > > > > >> > > > > > > > > > Please vote on releasing this package as Apache Knox > >> 1.4.0. > >> > > > > > > > > > The vote is open for the next 72 hours and passes if a > >> > > majority > >> > > > > of > >> > > > > > at > >> > > > > > > > > > least three +1 Apache Knox PMC votes are cast. > >> > > > > > > > > > > >> > > > > > > > > > [ ] +1 Release this package as Apache Knox 1.4.0 > >> > > > > > > > > > [ ] -1 Do not release this package because... > >> > > > > > > > > > > >> > > > > > > > > > thanks, > >> > > > > > > > > > > >> > > > > > > > > > --larry > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > >
