Dan Burkert has posted comments on this change. Change subject: cmake: add support for out-of-tree builds ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/1755/5/CMakeLists.txt File CMakeLists.txt: Line 558: # Ideally this would run only when the test is built, not when cmake runs, Does this mean that if you change the test script, CMake must be re-run? http://gerrit.cloudera.org:8080/#/c/1755/5/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: Line 109: rm -rf $BUILD_ROOT Doesn't this force a full recompilation of Kudu? Is it enough to only remove the logs directory? http://gerrit.cloudera.org:8080/#/c/1755/5/src/kudu/scripts/benchmarks.sh File src/kudu/scripts/benchmarks.sh: Line 177: rm -rf build can we keep it as just removing the cmake files? This saves may save on recompilation time. http://gerrit.cloudera.org:8080/#/c/1755/5/src/kudu/scripts/tpch.sh File src/kudu/scripts/tpch.sh: Line 99: rm -rf build same here. -- To view, visit http://gerrit.cloudera.org:8080/1755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76e17a1102b79ac0e25a505b54347db3bb436ede Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
