Adar Dembo has posted comments on this change. Change subject: cmake: add support for out-of-tree builds ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/1755/5/CMakeLists.txt File CMakeLists.txt: Line 558: # Ideally this would run only when the test is built, not when cmake runs, > Does this mean that if you change the test script, CMake must be re-run? As written, yes. Because it's not a dependency, even "make" won't re-copy; you actually have to manually invoke cmake. I looked into avoiding the copy. The issue is that the two script-based tests we have (client_symbol-test.sh and client_samples-test.sh) need to know where the build output is. Previously the build output was in a fixed location, and so the relative path to it could be hardcoded, but that's no longer guaranteed. I opted to copy the scripts into the build output in lieu of exposing the build directory to all tests via an environment variable, which I think is less clean. http://gerrit.cloudera.org:8080/#/c/1755/5/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: Line 109: rm -rf $BUILD_ROOT > Doesn't this force a full recompilation of Kudu? Is it enough to only remo Yes, this forces a full recompilation, but blowing away the build directory is simpler and less error-prone than removing individual files. See L208 in the old code: we used to 'make clean', so clearly we didn't care much for reusing old build output. http://gerrit.cloudera.org:8080/#/c/1755/5/src/kudu/scripts/benchmarks.sh File src/kudu/scripts/benchmarks.sh: Line 177: rm -rf build > can we keep it as just removing the cmake files? This saves may save on re See L184 in the old code; we were already using 'make clean', so I'd rather keep it simple (and less error-prone) and delete the entire build directory. http://gerrit.cloudera.org:8080/#/c/1755/5/src/kudu/scripts/tpch.sh File src/kudu/scripts/tpch.sh: Line 99: rm -rf build > same here. Same answer (L106 in the old code). -- To view, visit http://gerrit.cloudera.org:8080/1755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76e17a1102b79ac0e25a505b54347db3bb436ede Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
