Adar Dembo has posted comments on this change.

Change subject: cmake: add support for out-of-tree builds
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1755/5/CMakeLists.txt
File CMakeLists.txt:

Line 558:     # Ideally this would run only when the test is built, not when 
cmake runs,
> My concern is that if I were to go in and make changes to client_symbol-tes
Ahh, symlinking is a good idea. Thanks! I've made the change here and to 
twitter-demo/CMakeLists.txt.


-- 
To view, visit http://gerrit.cloudera.org:8080/1755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e17a1102b79ac0e25a505b54347db3bb436ede
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Martin Grund <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to