Mike Percy has posted comments on this change. Change subject: Mark peer responsive when remote bootstrap is in progress ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/1759/2/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 309: if (!(rb_response_.error().code() == I think this calls for plumbing a new TabletServerErrorPB::Code with something like TabletServerErrorPB::REMOTELY_BOOTSTRAPPING instead of trying to rely on IllegalState. Line 317: // TODO: we use this method both for error and success cases, so perhaps it The queue internally does some of its own accounting, so that's why it doesn't expose a "non-error" notification mechanism. http://gerrit.cloudera.org:8080/#/c/1759/2/src/kudu/tserver/remote_bootstrap_session.cc File src/kudu/tserver/remote_bootstrap_session.cc: Line 93: VLOG(1) << "Opening block " << block_id.DebugString(); If we VLOG this, maybe we should LOG(INFO) a message saying "T xxxx P yyyy: Remote bootstrap: Opening blocks" for debugging purposes but only once outside this loop. -- To view, visit http://gerrit.cloudera.org:8080/1759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic41f2ad31c437f6ab976987262d8b35f9aa9f3ad Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin Chang <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
