Binglin Chang has posted comments on this change. Change subject: Mark peer responsive when remote bootstrap is in progress ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/1759/4/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 318: queue_->NotifyPeerIsResponsiveDespiteError(peer_pb_.permanent_uuid()); > We should only call this when code == ALREADY_INPROGRESS Even when there is no error and the rpc succeed? Why? -- To view, visit http://gerrit.cloudera.org:8080/1759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic41f2ad31c437f6ab976987262d8b35f9aa9f3ad Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin Chang <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
