Binglin Chang has posted comments on this change. Change subject: Mark peer responsive when remote bootstrap is in progress ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/1759/2/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 309: if (!(rb_response_.error().code() == > I think this calls for plumbing a new TabletServerErrorPB::Code with someth How about ALREADY_INPROGRESS ? So maybe it can be used in other future scenarios. Currently in server side, all errors in remotebootstrap are set to UNKOWN_ERROR, to set error code in handler, we need to add a output parameter error_code in TSTabletManager::StartRemoteBootstrap, but I notice this: // Currently this runs the entire procedure synchronously. // TODO: KUDU-921: Run this procedure on a background thread. virtual Status StartRemoteBootstrap(const consensus::StartRemoteBootstrapRequestPB& req) OVERRIDE; So in the future this call may became async, not sure adding a output parameter still make sense. Line 317: // TODO: we use this method both for error and success cases, so perhaps it > The queue internally does some of its own accounting, so that's why it does OK -- To view, visit http://gerrit.cloudera.org:8080/1759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic41f2ad31c437f6ab976987262d8b35f9aa9f3ad Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin Chang <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
