Mike Percy has posted comments on this change. Change subject: Send back an error when UpdateConsensus cannot prepare a single transaction ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/1785/4/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1128: if (deduped_req.messages.empty()) > so if the leader sent a duplicate message (meaning we deduped everything) w This code is a bit confusing because of memory cleanup / erasing done in the code block above. But this just means if nothing was successfully prepared, in the case that there were valid deduped requests. Maybe we should add a larger block comment about that. Line 1135: IllegalState I'd rather we go with something similar to rev 3 but add a conditional to consensus_peers.cc:247 to handle that case. Sending this back as an unknown error is kind of lame and kind of piles onto the existing error handling tech debt. -- To view, visit http://gerrit.cloudera.org:8080/1785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I546fd3069af974383c23acb7406ea621e6962bb3 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
