Mike Percy has posted comments on this change.

Change subject: Send back an error when UpdateConsensus cannot prepare a single 
transaction
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1785/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

Line 1138:         FillConsensusResponseError(response, 
ConsensusErrorPB::INVALID_TERM,
> > Yea I'd say a new one like CANNOT_PREPARE or something? do we know the ty
Even so, theoretically the leader should be able to detect that its last 
attempt to replicate log entries to the follower resulted in no progress. In 
that case it could go into backoff mode, even without additional special error 
conditions on the follower. However in cases where there are no writes 
occurring that could be normal so we need to be a bit careful


-- 
To view, visit http://gerrit.cloudera.org:8080/1785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I546fd3069af974383c23acb7406ea621e6962bb3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to