Jean-Daniel Cryans has posted comments on this change. Change subject: Send back an error when UpdateConsensus cannot prepare a single transaction ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/1785/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1132: if (deduped_req.messages.empty()) { > I think this should be: I'll just add the comment. http://gerrit.cloudera.org:8080/#/c/1785/2/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: Line 2424: TEST_F(RaftConsensusITest, TestUpdateConsensusErrorNonePrepared) { > I'd feel better about this test if it somehow tested that it indeed caused We talked offline and you seemed to be ok with the current test. Line 2432: // Elect server 2 as leader. > It's not necessary to elect someone here, you can just act as a leader dire Done Line 2468: ASSERT_TRUE(resp.status().has_error()); > add: Done -- To view, visit http://gerrit.cloudera.org:8080/1785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I546fd3069af974383c23acb7406ea621e6962bb3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
