David Ribeiro Alves has posted comments on this change. Change subject: cmake: require out-of-tree builds ......................................................................
Patch Set 9: Code-Review-2 What is the point of this "requirement"? I've actually gone back to having in tree builds and add the missing entries to my gitignore_global, since the sibling out of tree stuff seriously broke my workflow (need to go back and forth between directories, eclipse git integration doesn't work with sibling out-of-tree) and the child out-of-tree option doesn't work with eclipse. Would prefer this is not made a requirement. -- To view, visit http://gerrit.cloudera.org:8080/1762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a9eab7d35419a3668b9dce384a049cddd1afef Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
