David Ribeiro Alves has posted comments on this change. Change subject: cmake: require out-of-tree builds ......................................................................
Patch Set 9: yeah, from experience with impala, it would be much better not to have cmake wrapping scripts. Regarding the pros/cons, I don't personally like the sibling dir route cuz it makes me go back and forth to do diff/use binaries (not just because eclipse's git integration doesn't work on sibling directories). If there's some way to do it, I wouldn't be opposed to making cmake have the behavior you described as the default behavior if I would be able to pass some extra flags to modify it to get what I have now, but as things are I would not to make a requirement. -- To view, visit http://gerrit.cloudera.org:8080/1762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a9eab7d35419a3668b9dce384a049cddd1afef Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
