Dan Burkert has posted comments on this change. Change subject: cmake: require out-of-tree builds ......................................................................
Patch Set 9: Regarding #2 and providing a script to set up the cmake skeleton- Martin said before he left that one of big mistakes that were made with Impala's build system was to put a shell script wrapper around CMake. I'm not 100% sure of all the reasons, but I think it allowed a lot of complexity and cruft to creep into the build. -- To view, visit http://gerrit.cloudera.org:8080/1762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a9eab7d35419a3668b9dce384a049cddd1afef Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
