Mike Percy has uploaded a new patch set (#2). Change subject: client: Some simplifying cleanups and renames ......................................................................
client: Some simplifying cleanups and renames This patch removes the capability to look up a tablet in the cache by id via a public API. That API was not actually required by any callers, and there was a sketchy CHECK in there that enforced a tablet_id hit in the cache, meaning there were sharp edges that had to be avoided. Additionally, this patch renames RefreshProxy -> InitProxy and related functions and removes the "force" bool that was never used by any callers. There isn't really a reason to "refresh" a proxy unless somehow the IP address had changed, which we don't currently support. When that support gets added, the implementer can add whatever APIs make sense at that time. Change-Id: I3e825848c6edae69ae5a13e52eaf1e8b9dacb130 --- M src/kudu/client/batcher.cc M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/scanner-internal.cc 7 files changed, 27 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/1882/2 -- To view, visit http://gerrit.cloudera.org:8080/1882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3e825848c6edae69ae5a13e52eaf1e8b9dacb130 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
