Todd Lipcon has posted comments on this change.

Change subject: client: Some simplifying cleanups and renames
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1882/2/src/kudu/client/meta_cache.cc
File src/kudu/client/meta_cache.cc:

Line 102:     if (proxy_) {
I guess I'm all for removing unused parameters, but one of the reasons for the 
'force' was to be able to re-resolve the host on various types of connection 
errors. we can always put it back later, just wanted to explain the original 
intent.


-- 
To view, visit http://gerrit.cloudera.org:8080/1882
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e825848c6edae69ae5a13e52eaf1e8b9dacb130
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to