Mike Percy has posted comments on this change. Change subject: client: Some simplifying cleanups and renames ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1882/2/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: Line 102: if (proxy_) { > I guess I'm all for removing unused parameters, but one of the reasons for OK, I wasn't sure who put it in. Let me know if you would prefer I revert this part of the patch and I'll do it. -- To view, visit http://gerrit.cloudera.org:8080/1882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e825848c6edae69ae5a13e52eaf1e8b9dacb130 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
