Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-842. Implement Operation.toString() in Java client ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/1945/1/java/kudu-client/src/test/java/org/kududb/client/TestOperation.java File java/kudu-client/src/test/java/org/kududb/client/TestOperation.java: Line 147: assertEquals("(int8 key0=1, int16 key1=2, int32 key2=3, int64 key3=4, timestamp key4=5, " + > I'm a little confused why we want the stringified key to say 'keyN' instead Oh reading the encoded_key-test got me confused, I thought that was how the C++ side was doing it, but the keys were actually named "key1, key2, etc". > why not just reuse the existing ability to stringify a row We currently don't have that in Java. -- To view, visit http://gerrit.cloudera.org:8080/1945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia258bc9bd4140ae0085bebe51935b465dac43db9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
