Todd Lipcon has posted comments on this change. Change subject: KUDU-842. Implement Operation.toString() in Java client ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1945/2/java/kudu-client/src/main/java/org/kududb/client/RowKeyStringifier.java File java/kudu-client/src/main/java/org/kududb/client/RowKeyStringifier.java: Line 55: value.reset(); > It was most likely read when the row was serialized so the position would b Does that make toString() non thread-safe? For example, if you try to use it on an operation that's in-flight, it might end up reset()ing a buffer that's being written to the wire? This seems like a pretty sketchy way of using the buffers. -- To view, visit http://gerrit.cloudera.org:8080/1945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia258bc9bd4140ae0085bebe51935b465dac43db9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
