Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-842. Implement Operation.toString() in Java client ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/1945/3/java/kudu-client/src/main/java/org/kududb/client/PartialRow.java File java/kudu-client/src/main/java/org/kududb/client/PartialRow.java: Line 553: sb.append(Bytes.getByte(getRowAlloc(), schema.getColumnOffset(i))); > now that it's a member function, is the getter really necessary? seems odd. Err no, not that it changes much. -- To view, visit http://gerrit.cloudera.org:8080/1945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia258bc9bd4140ae0085bebe51935b465dac43db9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
