Dan Burkert has posted comments on this change. Change subject: Create design docs directory and add partition pruning design doc ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/2149/2/docs/design-docs/partition-pruning.md File docs/design-docs/partition-pruning.md: Line 21: predicates specified in the primary key bounds are 'lifted' into the predicates, > I think it's worth adding a little 'preliminaries' section with a sub-secti Done Line 27: CREATE TABLE 't' > I think it's worth adding a simpler example table, with a more real-world s Done Line 32: RANGE (b, c) SPLIT ROWS [(10, 0)]; > would be nice for these example tables to actually enumerate the tablets (m Done Line 68: ``` > can you add a comment here showing the "lifted" predicates right below the Done Line 84: WHERE b = 12 > missing 'AND' Done Line 105: pruning can occur. Pruned tablets never need to be contacted (though their > hrm, this still requires that the client fetch the whole list of tablets? t I've incorporated a more fleshed out version my comment into the document. Would like feedback on the partition key bounds vs. interval tree alternative, I could go either way. -- To view, visit http://gerrit.cloudera.org:8080/2149 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifacf3667f364286bf5a5f0c4931328035a9b517e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Misty Stanley-Jones <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
