Todd Lipcon has posted comments on this change. Change subject: Create design docs directory and add partition pruning design doc ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2149/2/docs/design-docs/partition-pruning.md File docs/design-docs/partition-pruning.md: Line 105: pruning can occur. Pruned tablets never need to be contacted (though their > I've incorporated a more fleshed out version my comment into the document. It's not so much an interval tree (the data structure) as a list of intervals, right? I suppose it makes sense that we can leave this optimization til later (if we see it become necessary). I do think the case of a time range scan on a table range-partitioned by time and hash-partitioned by something else is reasonably common. But we can absorb the cost of fetching all tablets for the time being. Line 108: The server will go one step further by adding the server's primary key bounds to > It's a little bit contrived, but consider this: oh... yea, that's pretty contrived :) If the optimization here is basically free (CPU-wise) to apply, we might as well, I guess, but if it's gonna add any extra constant CPU cost to scans in the 99% case, it might not be worth it. I think it's worth checking the cost/benefit here before making a final call. -- To view, visit http://gerrit.cloudera.org:8080/2149 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifacf3667f364286bf5a5f0c4931328035a9b517e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Misty Stanley-Jones <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
