Todd Lipcon has posted comments on this change.

Change subject: Create design docs directory and add partition pruning design 
doc
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/2149/4/docs/design-docs/scan-optimization-partition-pruning.md
File docs/design-docs/scan-optimization-partition-pruning.md:

Line 67: between then column predicates and primary key bounds when possible. 
This is
typo: then -> the


Line 76:       primary_key < (500, 750);
can you add an 'AND' here to make it more sql-y?


Line 116: can prune tablets `B` and `C`.
not B and D?


Line 217: set of tablets necessary to satisfy the scan.
I wonder whether we'll need to add this API anyway for use by query planners. 
Just an idle thought.


-- 
To view, visit http://gerrit.cloudera.org:8080/2149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifacf3667f364286bf5a5f0c4931328035a9b517e
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Misty Stanley-Jones <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to