David Ribeiro Alves has posted comments on this change. Change subject: rpc: add negotiation of RPC-layer feature flags ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2238/1//COMMIT_MSG Commit Message: Line 33: but I didn't want to feature-creep into a wholesale rename or refactor, I think the feature-creep here is appropriate, if we making it do more than sasl we should refactor and rename appropriately. also seems like this would be the place to do more work at negotiating time, if we ever need it http://gerrit.cloudera.org:8080/#/c/2238/1/src/kudu/rpc/constants.h File src/kudu/rpc/constants.h: Line 22: extra line -- To view, visit http://gerrit.cloudera.org:8080/2238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c7fdf03920496c12d92eba23d8d4f7b7cb8fc5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
