Todd Lipcon has posted comments on this change. Change subject: rpc: add negotiation of RPC-layer feature flags ......................................................................
Patch Set 2: (2 comments) a couple small nits on the code. I think JD's comment about putting some of this design/doc into the rpc design doc (docs/design-docs/rpc.md) still stands. Probably could copy-paste from the commit message. I think David's comment about refactoring/rename is a good one, but I'd prefer to put that refactor in a follow-on commit so that this one is still nice and self-contained (hard to review refactor and improvement in the same patch) http://gerrit.cloudera.org:8080/#/c/2238/2/src/kudu/rpc/negotiation.h File src/kudu/rpc/negotiation.h: Line 23: #include "kudu/rpc/rpc_header.pb.h" don't think these changes are necessary http://gerrit.cloudera.org:8080/#/c/2238/2/src/kudu/rpc/rpc_header.proto File src/kudu/rpc/rpc_header.proto: Line 98: // We use an int32 rather than that enum directly so that, if we receive a value I think this bit of the comment is not true in the current version of the patch -- there is no RpcSystemVersionNumber enum. I think I started off working on this patch assuming a linear version number instead of the "flags" thing it ended up with -- To view, visit http://gerrit.cloudera.org:8080/2238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c7fdf03920496c12d92eba23d8d4f7b7cb8fc5 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
