Dan Burkert has posted comments on this change. Change subject: rpc: add negotiation of RPC-layer feature flags ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/2238/1/src/kudu/rpc/constants.h File src/kudu/rpc/constants.h: Line 22: > extra line Done http://gerrit.cloudera.org:8080/#/c/2238/1/src/kudu/rpc/rpc_header.proto File src/kudu/rpc/rpc_header.proto: Line 60: UNKNOWN = 999; > This should probably be UNKNOWN = 0;. I don't think it matters for proto 2 Done http://gerrit.cloudera.org:8080/#/c/2238/1/src/kudu/rpc/sasl_client.h File src/kudu/rpc/sasl_client.h: Line 157: std::set<RpcFeatureFlag> server_features_; > could this be an unordered_set? RpcFeatureFlag is not hashable. -- To view, visit http://gerrit.cloudera.org:8080/2238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c7fdf03920496c12d92eba23d8d4f7b7cb8fc5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
