David Ribeiro Alves has posted comments on this change. Change subject: rpc: add negotiation of RPC-layer feature flags ......................................................................
Patch Set 5: (5 comments) I'm OK with deferring the refactor http://gerrit.cloudera.org:8080/#/c/2238/5/src/kudu/rpc/rpc_header.proto File src/kudu/rpc/rpc_header.proto: Line 58: . can you provide a negative example of what wouldn't be a rpcfeatureflag? Line 62: // TODO: as soon as we have any real feature flag, we can get rid nit: weird wrapping, likely fits 2 lines http://gerrit.cloudera.org:8080/#/c/2238/5/src/kudu/rpc/sasl_client.h File src/kudu/rpc/sasl_client.h: Line 64: Return s/Return/Returns Line 65: // Call after Negotiate(). s/Call/Must be called http://gerrit.cloudera.org:8080/#/c/2238/5/src/kudu/rpc/sasl_server.h File src/kudu/rpc/sasl_server.h: Line 64: // Return the set of RPC system features supported by the remote client. same as in the client -- To view, visit http://gerrit.cloudera.org:8080/2238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c7fdf03920496c12d92eba23d8d4f7b7cb8fc5 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
