Dan Burkert has posted comments on this change. Change subject: Fix Spark shutdown ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2571/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 235: this.channelFactory = b.createChannelFactory(); > I think you missed this comment. Maybe because createChannelFactory should happen after the user calls all the setters? I'm not really sure, that wouldn't prevent it from being called during AsyncKuduClientBuilder::build. -- To view, visit http://gerrit.cloudera.org:8080/2571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30a64ec5eb30d70361204646523c9947d88c251f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
