Dan Burkert has posted comments on this change. Change subject: Fix Spark shutdown ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/2571/3//COMMIT_MSG Commit Message: Line 9: The Kudu client was creating Netty timers with non-daemon threads, which led to > Could you update the commit message with our discussion regarding the preci Done http://gerrit.cloudera.org:8080/#/c/2571/3/java/kudu-spark/src/main/scala/org/kududb/spark/KuduContext.scala File java/kudu-spark/src/main/scala/org/kududb/spark/KuduContext.scala: Line 44: ShutdownHookManager.get().addShutdownHook(new Runnable { > To Steve Loughran's point (from that Spark email thread), can you audit the It looks like close() is actually the thing we need here, and we do have a timeout set on it: https://github.com/cloudera/kudu/blob/master/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java#L1352 Line 45: override def run() = syncClient.shutdown() > Please add a comment for this and the other shutdown hook explaining why th added it to the ShutdownHookPriority, so its just in one place. -- To view, visit http://gerrit.cloudera.org:8080/2571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30a64ec5eb30d70361204646523c9947d88c251f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
