Adar Dembo has posted comments on this change. Change subject: Fix Spark shutdown ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/2571/3//COMMIT_MSG Commit Message: Line 9: The Kudu client was creating Netty timers with non-daemon threads, which led to Could you update the commit message with our discussion regarding the precise need for both daemon threads (so that the JVM will even consider shutting down) and a shutdown hook (so that unflushed writes are flushed)? http://gerrit.cloudera.org:8080/#/c/2571/3/java/kudu-spark/src/main/scala/org/kududb/spark/KuduContext.scala File java/kudu-spark/src/main/scala/org/kududb/spark/KuduContext.scala: Line 44: ShutdownHookManager.get().addShutdownHook(new Runnable { To Steve Loughran's point (from that Spark email thread), can you audit the client's shutdown() path and make sure there are timeouts on every blocking operation? Line 45: override def run() = syncClient.shutdown() Please add a comment for this and the other shutdown hook explaining why they're needed. -- To view, visit http://gerrit.cloudera.org:8080/2571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30a64ec5eb30d70361204646523c9947d88c251f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
