Todd Lipcon has posted comments on this change. Change subject: KUDU-1165: Implement partition pruning for C++ client and server ......................................................................
Patch Set 19: Code-Review+1 (2 comments) Looks good modulo a couple typos. I think we should probably get another eye or two on it, though, to make sure that the description of the algorithm is sufficient for a new person to grok the code. http://gerrit.cloudera.org:8080/#/c/2413/19/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: Line 161: // Examples predicate sets and resulting partition key ranges, based on the typo: Examples Line 201: of as typo -- To view, visit http://gerrit.cloudera.org:8080/2413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f4fc14b44af63a17b34cd9c2a9134127b1afe4d Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
